Skip to content

Conversation

MarcoGorelli
Copy link
Member

  • Closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added: Please use assert_type() to assert the type of any return value

Copy link
Contributor

@cmp0xff cmp0xff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I am not familiar with changing default values from ... to a concrete value. I'll wait for @Dr-Irv this time.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @MarcoGorelli

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Sep 30, 2025

Looks good to me, but I am not familiar with changing default values from ... to a concrete value. I'll wait for @Dr-Irv this time.

Marco did this on some earlier PRs - it provides better documentation when we know there are default values.

@Dr-Irv Dr-Irv merged commit 50a9aa5 into pandas-dev:main Sep 30, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants